Code Changes for Updates

Jaeger is a modified/customized version of an upstream chart. The below details the steps required to update to a new version of the Jaeger package.

1. Navigate to the upstream chart repo and folder and find the tag that corresponds with the new chart version for this image update. For example, if updating the Jaeger images to 1.28 you would check the chart values and switch Gitlab tags until you find the latest chart version that uses 1.28 images. In this case that is jaeger-operator-2.27.0 (as of this doc construction).

2. Checkout the renovate/ironbank branch. This branch will already have the updates you need for the images.

3. From the root of the repo run kpt pkg update chart@jaeger-operator-2.27.0 --strategy alpha-git-patch replacing jaeger-operator-2.27.0 with the version tag you got in step 1. You may be prompted to resolve some conflicts - choose what makes sense (if there are BB additions/changes keep them, if there are upstream additions/changes keep them).

4. Modify the version in Chart.yaml - you will want to append -bb.0 to the chart version from upstream. update dependencies to latest BB gluon library version.

helm dependency update ./chart

1. Update CHANGELOG.md adding an entry for the new version and noting all changes (at minimum should include Updated Jaeger to x.x.x).

2. Generate the README.md updates by following the guide in gluon.

3. Push up your changes, validate that CI passes. If there are any failures follow the information in the pipeline to make the necessary updates and reach out to the team if needed.

4. Perform the steps below for manual testing. CI provides a good set of basic smoke tests but it is beneficial to run some additional checks.

Manual Testing for Updates

NOTE: For these testing steps it is good to do them on both a clean install and an upgrade. For clean install, point jaeger to your branch. For an upgrade do an install with jaeger pointing to the latest tag, then perform a helm upgrade with jaeger pointing to your branch.

You will want to install with:

• Jaeger, Logging (elastic, eck operator, and fluentbit), Kiali, Authservice and Monitoring packages enabled
• Istio enabled
• Dev SSO values for Kiali, Monitoring, and Jaeger

Testing Steps:

• Login with SSO to Jaeger (if you are not prompted for an SSO login, this could indicate a problem with the authservice connection)
• On the search fields on the left pick a service and click “find traces”. Validate that traces load.
• Navigate to Kiali and login with SSO, under applications find the namespace and service that corresponds with the service you picked in Jaeger earlier. Validate that traces show under the traces tab.
• Navigate to Prometheus and validate that the Jaeger operator targets show as UP.

When in doubt with any testing or upgrade steps ask one of the CODEOWNERS for assistance.

Modifications made to upstream chart

This is a high-level list of modifications that Big Bang has made to the upstream helm chart. You can use this as as cross-check to make sure that no modifications were lost during the upgrade process.

chart/templates/bigbang

• Files added to support networkPolicies, cert generation, monitoring, mTLS enforcement, VirtualService, etc

chart/Chart.yaml

• Append -bb.x versioning to version
• Add gluon dependency chart for helm tests (also run helm dependency update ./chart to store this):

  dependencies:
  - name: gluon
      version: 0.3.1
      repository: oci://registry.dso.mil/platform-one/big-bang/apps/library-charts/gluon
  

• Add bigbang dev annotation for release automation:

  annotations:
    bigbang.dev/applicationVersions: |
      - Jaeger: 1.34.1
  

chart/templates/_helpers.tpl

• Added selector label template to support upgrades

  {{/* Generate selector labels -- see issue #512.  This allows helm upgrades to happen */}}
  {{- define "jaeger-operator.selector.labels" }}
  app.kubernetes.io/name: {{ include "jaeger-operator.name" . }}
  {{- end }}
  

• Added name: {{ include "jaeger-operator.fullname" . }} to "jaeger-operator.labels" template

chart/templates/deployment.yaml

• Upgrade strategy added below spec.replicas:

  {{- if .Values.operatorUpdateStrategy }}
  strategy:
    {{- toYaml .Values.operatorUpdateStrategy | nindent 4 }}
  {{- end }}
  

• spec.selector.matchLabels changed to {{ include "jaeger-operator.selector.labels" . | nindent 6 }}
• Annotations values added below extraLabels:

  {{- if .Values.annotations }}
  annotations:
    {{ toYaml .Values.annotations | nindent 8 }}
  {{- end }}
  

• spec.template.spec.containers added securityContext

  securityContext:
  capabilities:
      drop:
      - ALL
  

• Changed ports: name: metrics to http-metrics

chart/templates/jaeger.yaml

• Changed name to jaeger
• Refactored to support certain parts of the spec rather than a simple toYaml (should we re-evaluate this?)
• added {{- if .Values.elasticsearch.enabled }} code block

chart/templates/psp.yaml

• added spec.securityContext code block

chart/templates/service.yaml

• Changed spec.ports -name: metrics to http-metrics

chart/templates/tests

• Gluon cypress test template added

chart/tests

• Cypress config and test added

chart/values.yaml

• Substantial values additions/changes to use IB images, support BB core interactions, etc
• When in doubt ask about these changes

---

Last update: 2023-01-13 by kevin.wilder